Add function to parse script from string #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Jun 27, 2021
scripts/unicode.py
Outdated
| #[inline] | ||
| pub(crate) fn inner_from_short_name(input: &str) -> Option<Self> { | ||
| match input { | ||
| "" => Some(Script::Unknown), |
There was a problem hiding this comment.
should this branch exist? Perhaps we should not return an Option and use Unknown as the catch all
There was a problem hiding this comment.
I think Option may be helpful, because if some folk will accidentally use from_short_name instead of from_full_namethey'll get a None, which is easier to find early.
There was a problem hiding this comment.
However, I'm not insisting, if you think that it's better to not use Option here, I'll be happy to change the code.
There was a problem hiding this comment.
I'm okay returning an Option but we shouldn't have the empty branch imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to discussion in rust-lang/rust-clippy#7400
r? @Manishearth